Update 3DS and GraphQL Endpoint Sent to FPTI #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
commented
Jul 23, 2024
| @@ -446,8 +446,12 @@ class BTHTTP: NSObject, URLSessionTaskDelegate { | |||
| let json = try? JSONSerialization.jsonObject(with: data) | |||
| let body = BTJSON(value: json) | |||
|
|
|||
| guard let mutationName = body["operationName"].asString() else { return nil } | |||
There was a problem hiding this comment.
The card GraphQL request is the only flow that uses operationName so for other flows such as Venmo we were sending the endpoint as /graphql. This update allows us to now send the expected query/mutation name.
There was a problem hiding this comment.
just curious - would this change affect us being able to fetch the mutation name for the card graphql flow 👀
There was a problem hiding this comment.
We still pass in a mutation as expected for the card flow, we just extract it from here:
vs concatenating the mutation string to theoperationName. So card is passed as mutation TokenizeCreditCard same as prior to this change.
jaxdesmarais
commented
Jul 23, 2024
jaxdesmarais
commented
Jul 23, 2024
1 task
scannillo
reviewed
Jul 24, 2024
richherrera
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
operationNamesince this is only present for card, causing us not to send the correct path for the Venmo flowChecklist
Authors