Add Optional merchantAccountID to PayPalVaultEditRequest #1383
Conversation
| @@ -5,13 +5,16 @@ import Foundation | |||
| public class BTPayPalVaultEditRequest { | |||
|
|
|||
| private let editPayPalVaultID: String | |||
| public var merchantAccountID: String? | |||
There was a problem hiding this comment.
| public var merchantAccountID: String? | |
| private let merchantAccountID: String? |
I agree with Jax. Also any reason we can't make this a data class?
There was a problem hiding this comment.
data class? Not sure what you mean. Did you mean struct?
I don't think there is a reason except for pre-existing pattern of using classes for requests.
I think that's from objective-c maybe?
There was a problem hiding this comment.
Oh wow yeah I'm getting confused I thought this was Kotlin lol. Sorry. I forgot that Objective-C and Swift structs don't mix well. Plz disregard.
There was a problem hiding this comment.
No worries. You do bring up a good point about use of classes for requests.
There was a problem hiding this comment.
I think this could be a struct. For new features, we're trying to experiment w/ seeing if we get merchant feedback by not offering Objective-C support (ex: ShopperInsights & CreditMessaging don't support Obj-C). If we need to switch it to class later for ObjC bridging we can, but I like the idea of using a struct!
|
|
||
| // TODO: specify endpoint for merchant to retrieve the token | ||
| /// Initializes a PayPal Edit Request for the edit funding instrument flow | ||
| /// - Parameters: | ||
| /// - editPayPalVaultID: Required: The `edit_paypal_vault_id` returned from the server side request | ||
| /// merchantAccountIdD: optional ID of the merchant account; if one is not provided the default will be used |
There was a problem hiding this comment.
| /// merchantAccountIdD: optional ID of the merchant account; if one is not provided the default will be used | |
| /// merchantAccountID: optional ID of the merchant account; if one is not provided the default will be used |
Summary of changes
Checklist
Authors