[v7] Update BTThreeDSecureRequest Parameters
#1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agedd
changed the title
BTThreeDSecureRequest Required ParametersBTThreeDSecureRequest Parameters
agedd
commented
Nov 5, 2024
agedd
commented
Nov 5, 2024
agedd
changed the title
BTThreeDSecureRequest ParametersBTThreeDSecureRequest Parameters
warmkesselj
approved these changes
Nov 6, 2024
saperi22
approved these changes
Nov 13, 2024
| accountType: BTThreeDSecureAccountType = .unspecified, | ||
| additionalInformation: BTThreeDSecureAdditionalInformation? = nil, | ||
| billingAddress: BTThreeDSecurePostalAddress? = nil, | ||
| _cardAddChallenge: BTThreeDSecureCardAddChallenge = .unspecified, |
There was a problem hiding this comment.
nit: we can probably just leave this out of the init for now then remove it in the ticket to remove the property completely. If that's more work than it's worth though, feel free to leave and we can hopefully pick up that cleanup ticket soon!
agedd
deleted the
dtmobiles-1134-update-btthreedsecurerequest-required-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTThreeDSecureRequestproperties to have everything in the init vs using dot syntaxChecklist
Authors