Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V7] Remove MXO #1454

Merged
merged 23 commits into from
Nov 5, 2024
Merged

[V7] Remove MXO #1454

merged 23 commits into from
Nov 5, 2024

Conversation

richherrera
Copy link
Contributor

Summary of changes

  • Remove PayPal Native Checkout module as it is no longer supported in v7

Checklist

  • Added a changelog entry

Authors

@richherrera richherrera requested a review from a team as a code owner November 4, 2024 17:45
@richherrera richherrera self-assigned this Nov 4, 2024
@richherrera richherrera added the v7 label Nov 4, 2024
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will also want to remove publishing the docs here:

sourcekitten doc -- -workspace Braintree.xcworkspace -scheme BraintreePayPalMessaging -destination 'name=iPhone 14,platform=iOS Simulator' > braintree-paypal-messaging.json
and here:
jq -s '.[0] + .[1] + .[2] + .[3] + .[4] + .[5] + .[6] + .[7] + .[8] + .[9] + .[10] + .[11] + .[12]' braintree-core.json braintree-pay-pal-native-checkout.json braintree-sepa-direct-debit.json braintree-american-express.json braintree-data-collector.json braintree-apple-pay.json braintree-local-payment.json braintree-three-d-secure.json braintree-card.json braintree-paypal.json braintree-venmo.json braintree-paypal-messaging.json braintree-shopper-insights.json > swiftDoc.json

@warmkesselj
Copy link
Contributor

@richherrera I did a quick scan for PayPal Native and found this comment in BTPayPalCheckoutRequest; is there more that can be removed in this class?

/// :nodoc: Exposed publicly for use by PayPal Native Checkout module. This method is not covered by semantic versioning.`

@richherrera
Copy link
Contributor Author

I think we will also want to remove publishing the docs here:

sourcekitten doc -- -workspace Braintree.xcworkspace -scheme BraintreePayPalMessaging -destination 'name=iPhone 14,platform=iOS Simulator' > braintree-paypal-messaging.json

and here:

jq -s '.[0] + .[1] + .[2] + .[3] + .[4] + .[5] + .[6] + .[7] + .[8] + .[9] + .[10] + .[11] + .[12]' braintree-core.json braintree-pay-pal-native-checkout.json braintree-sepa-direct-debit.json braintree-american-express.json braintree-data-collector.json braintree-apple-pay.json braintree-local-payment.json braintree-three-d-secure.json braintree-card.json braintree-paypal.json braintree-venmo.json braintree-paypal-messaging.json braintree-shopper-insights.json > swiftDoc.json

👍 Updated 5cc201d, can you take a look please? thanks

@richherrera
Copy link
Contributor Author

@richherrera I did a quick scan for PayPal Native and found this comment in BTPayPalCheckoutRequest; is there more that can be removed in this class?

/// :nodoc: Exposed publicly for use by PayPal Native Checkout module. This method is not covered by semantic versioning.`

Thanks for the heads up, I removed all those types of comments and validated that everything works correctly. Let me know what you think

Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for tackling this @richherrera 🚀

@richherrera richherrera merged commit 2d82d28 into v7 Nov 5, 2024
7 of 8 checks passed
@richherrera richherrera deleted the remove-mxo branch November 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants