Update PayPal Messaging UI Test #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The test
testStart_withValidRequest_firesDelegateshas been failing recently. Upon investigation the text forPayPal - Pay monthly for purchases of $199-$10,000. Learn morehas changed toPayPal - Pay monthly for purchases of $49-$10,000. Learn more. This is likely due to a backend change to vary the offers in some cases. Instead of just hardcoding the new value since we now know this can change, I opted to useNSPredicatefor the portion of the text that we likely do not expect to change. This should hopefully keep our test more flexible with changes the messaging team may make to the text on the back end.Checklist
[ ] Added a changelog entryAuthors