Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BTPayPalRequest with App Switch Properties #1465

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Update BTPayPalRequest with App Switch Properties #1465

merged 6 commits into from
Nov 22, 2024

Conversation

agedd
Copy link
Contributor

@agedd agedd commented Nov 14, 2024 •
edited
Loading

Summary of changes

  • Update BTPayPalRequest with app-switch properties, enablePayPalAppSwitch and userAuthenticationEmail
  • Remove these properties from BTPayPalVaultRequest
  • Add init to BTPayPalCheckoutRequest with these properties
  • Tested and verified app switch flow for vaulting works as expected (the checkout flow is not yet expected to work)

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd agedd requested a review from a team as a code owner November 14, 2024 20:53
jaxdesmarais
jaxdesmarais reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the base branch as the feature branch. Lets also try not to have the internal ticket number in the branch name in the future.

@agedd agedd changed the base branch from main to app-switch-checkout-feature November 15, 2024 15:32
jaxdesmarais
jaxdesmarais reviewed Nov 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Sources/BraintreePayPal/BTPayPalCheckoutRequest.swift Outdated Show resolved Hide resolved
richherrera
richherrera approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Sources/BraintreePayPal/BTPayPalRequest.swift Show resolved Hide resolved
jaxdesmarais
jaxdesmarais approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@agedd agedd merged commit e9b5a7e into app-switch-checkout-feature Nov 22, 2024
8 checks passed
@agedd agedd deleted the dtmobiles-1183-update-`btpaypalrequest`-with-app-switch branch November 22, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richherrera richherrera richherrera approved these changes

@scannillo scannillo scannillo approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agedd @jaxdesmarais @scannillo @richherrera