[V7] Add Encodable protocol for Local Payments.
#1468
Conversation
| case currencyCode = "currency_iso_code" | ||
| case paymentTypeCountryCode = "payment_type_country_code" | ||
| case merchantAccountID = "merchant_account_id" | ||
| case email = "payer_email" |
There was a problem hiding this comment.
After reviewing Android, I noticed we’re not sending the same parameters, such as email, phone, givenName, surname, bic, and merchantAccountId. I verified with the LPMS team the keys needed to send these parameters. It seems the gateway supports both camel case and snake case, web and Android use camel case.
| @@ -9,7 +9,12 @@ import BraintreeDataCollector | |||
| #endif | |||
|
|
|||
| /// Used to initialize a local payment flow | |||
| @objcMembers public class BTLocalPaymentRequest: NSObject { | |||
| /// The POST body for v1/local_payments/create | |||
| @objcMembers public class BTLocalPaymentRequest: NSObject, Encodable { | |||
There was a problem hiding this comment.
Take it or leave it but we could also consider separating the encodable portion out into a new file, we've done that in most places where we've made this change, like here for example: https://github.com/braintree/braintree_ios/blob/main/Sources/BraintreeSEPADirectDebit/SEPADebitAccountsRequest.swift
There was a problem hiding this comment.
Sure, updated: 3e00b0e what do you think??
| if let address { | ||
| try container.encodeIfPresent(address.streetAddress, forKey: .streetAddress) | ||
| try container.encodeIfPresent(address.extendedAddress, forKey: .extendedAddress) | ||
| try container.encodeIfPresent(address.locality, forKey: .locality) | ||
| try container.encodeIfPresent(address.countryCodeAlpha2, forKey: .countryCodeAlpha2) | ||
| try container.encodeIfPresent(address.postalCode, forKey: .postalCode) | ||
| try container.encodeIfPresent(address.region, forKey: .region) | ||
| } |
There was a problem hiding this comment.
Take it or leave it - instead of needing a custom Encoder implementation, we could have the init take in a BTPostalAddress param, but then the private properties on this struct are the actual encodable types.
Roughly something like:
private let amount: String
private var streetAddress: String?
private var extendedAddress: String?
init(amount: String, ... the other stuff, address: BTPostalAddress?) {
self.amount = amount
self.streetAddress = address.streetAddress
self.extendedAddress = address.extendedAddress
}
Then we wouldn't need to override encode().
Which is more readable? I go back and forth sometimes with the custom encoder being more or less explicit.
There was a problem hiding this comment.
Updated: 3e00b0e
Summary of changes
postbodies used in the Local Payment flow.Checklist
[ ] Added a changelog entryAuthors