Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RP1][iOS] Expose PayPal and Venmo App Installed for Merchants #1473

Merged
merged 10 commits into from
Dec 6, 2024
Merged

[RP1][iOS] Expose PayPal and Venmo App Installed for Merchants #1473

merged 10 commits into from
Dec 6, 2024

Conversation

stechiu
Copy link
Collaborator

@stechiu stechiu commented Nov 22, 2024 •
edited
Loading

For Shopper Insights, we want to create a public BTPayPalClient.isPayPalAppInstalled method and public BTVenmoClient.isVenmoAppInstalled method in BTPayPalClient

Summary of changes

  • Added BTPayPalClient.isPayPalAppInstalled and BTVenmoClient.isVenmoAppInstalled methods
  • Added unit tests

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner November 22, 2024 23:43
@stechiu stechiu changed the base branch from main to shopper-insights-rp1-feature November 23, 2024 00:22
scannillo
scannillo reviewed Dec 5, 2024
View reviewed changes
Podfile.lock Outdated Show resolved Hide resolved
@stechiu stechiu merged commit 6b3450b into shopper-insights-rp1-feature Dec 6, 2024
8 checks passed
@stechiu stechiu deleted the paypal-venmo-installed branch December 6, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo left review comments

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stechiu @jaxdesmarais @scannillo @sarahkoop