Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopper insights rp1 feature fixes from main merge #1490

Conversation

warmkesselj
Copy link
Contributor

Summary of changes

Fixing a bad merge from main branch

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@jwarmkessel
@warmkesselj

@warmkesselj warmkesselj requested a review from a team as a code owner December 19, 2024 22:39
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a couple of tests that are still failing that we should address

CHANGELOG.md Outdated
Comment on lines 14 to 16
* BraintreeShopperInsights (BETA)
* Add `shopperSessionID` to `BTShopperInsightsClient` initializer
* Add `isPayPalAppInstalled()` and/or `isVenmoAppInstalled()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of this should be under an unreleased section. It did not get released in 6.25.0. Also missing this entry:
Add shopperSessionID to BTPayPalCheckoutRequest and BTPayPalVaultRequest

@warmkesselj warmkesselj merged commit b02bb43 into shopper-insights-rp1-feature Dec 20, 2024
8 checks passed
@warmkesselj warmkesselj deleted the shopper-insights-rp1-feature-fixes-from-main-merge branch December 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants