Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use strconv.ParseInt for 64-bit values on 32-bit systems #87

Conversation

Codycody31
Copy link
Contributor

Fixes issue #86 by swapping strconv.Atoi with strconv.ParseInt to handle large file sizes correctly on 32-bit systems. No testing is really needed, but I can confirm that the old code using Atoi would fail for a file size such as ~5-6 GiB, with the update supporting way larger files (tested with a 21 GiB file).

@bramvdbogaerde bramvdbogaerde merged commit 5ac8595 into bramvdbogaerde:master Jun 21, 2024
1 check passed
@bramvdbogaerde
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants