Skip to content

Commit

Permalink
Test command shouldn't update branding.
Browse files Browse the repository at this point in the history
  • Loading branch information
goodov committed Nov 19, 2022
1 parent cc79dee commit 5a93194
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
3 changes: 2 additions & 1 deletion build/commands/lib/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
config.update(options)
checkVersionsMatch()

util.touchOverriddenFilesAndUpdateBranding()
util.touchOverriddenFiles()
util.updateBranding()

if (config.xcode_gen_target) {
util.generateXcodeWorkspace()
Expand Down
2 changes: 1 addition & 1 deletion build/commands/lib/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const test = (passthroughArgs, suite, buildConfig = config.defaultBuildConfig, o
} else {
config.buildTarget = suite
}
util.touchOverriddenFilesAndUpdateBranding()
util.touchOverriddenFiles()
util.buildTarget()

// Filter out upstream tests that are known to fail for Brave
Expand Down
7 changes: 3 additions & 4 deletions build/commands/lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ const util = {
}
},

touchOverriddenFiles: () => {
touchOverriddenChromiumSrcFiles: () => {
console.log('touch original files overridden by chromium_src...')

// Return true when original file of |file| should be touched.
Expand Down Expand Up @@ -465,10 +465,9 @@ const util = {
})
},

touchOverriddenFilesAndUpdateBranding: () => {
util.touchOverriddenFiles()
touchOverriddenFiles: () => {
util.touchOverriddenChromiumSrcFiles()
util.touchOverriddenVectorIconFiles()
util.updateBranding()
},

// Chromium compares pre-installed midl files and generated midl files from IDL during the build to check integrity.
Expand Down

0 comments on commit 5a93194

Please sign in to comment.