Support pinning of solana tokens #16963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypt4
force-pushed
the
brave_28000
branch
2 times, most recently
from
52e3eaa to
4aa17f0
Compare
supermassive
reviewed
Feb 9, 2023
Comment on lines
523
to
653
| absl::optional<std::string> service, | ||
| mojom::BlockchainTokenPtr token, |
There was a problem hiding this comment.
const & for service and token
supermassive
reviewed
Feb 9, 2023
Comment on lines
322
to
325
| FetchMetadata(*url, | ||
| base::BindOnce(&NftMetadataFetcher::CompleteGetSolTokenMetadata, | ||
| weak_ptr_factory_.GetWeakPtr(), url.value(), | ||
| std::move(callback))); |
There was a problem hiding this comment.
Both either *url or url.value() to be consistent
supermassive
reviewed
Feb 9, 2023
| @@ -31,7 +31,8 @@ const char kErrorMessage[] = "error_message"; | |||
| const char kAssetUrlListKey[] = "cids"; | |||
|
|
|||
| namespace { | |||
|
|
|||
| // Solana NFTs doesn't have token_id | |||
supermassive
reviewed
Feb 9, 2023
| mojom::BlockchainTokenPtr token, | ||
| const std::string& token_url, | ||
| const std::string& result, | ||
| AddPinCallback callback) { | ||
| GURL token_gurl = GURL(token_url); | ||
| if (!token_gurl.SchemeIs(ipfs::kIPFSScheme)) { |
There was a problem hiding this comment.
Should we also fail here if whole url is not valid?
There was a problem hiding this comment.
There is only one check for url to have ipfs scheme, not sure if it is enough.
supermassive
approved these changes
Feb 9, 2023
cypt4
force-pushed
the
brave_28000
branch
3 times, most recently
from
a34fbf0 to
662cc44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28000
Solana doesn't have token_id so we use * as token_id in the GetTokenPrefPath to construct token preference path.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Test pinning SOL token pinning. Ex: https://magiceden.io/item-details/7tSu4udrnQXbs92ocYboCCHMxpmq1ufDyxzGMmzY62UL