Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Solana Dropped Transaction Panel #26747

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Nov 26, 2024

Description

Fixes a bug where all dropped Solana transactions would show a continues Loading Spinner in the Panel

note:(Transaction details bug found during fix, will handle in a separate PR brave/brave-browser#42516)

Resolves brave/brave-browser#42514

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create a Solana transaction that will be dropped
  2. Wait on the Post Confirmation panel until the transaction is dropped
  3. It should show the Failed Transaction panel, not a Loading spinner forever.
Screen.Recording.8.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 26, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 26, 2024 04:49
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Nov 26, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit 426f3bb into master Nov 26, 2024
18 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-solana-dropped-transaction-panel branch November 26, 2024 16:59
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 26, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.54

@srirambv
Copy link
Contributor

srirambv commented Dec 5, 2024

@kjozwiak this should be ok to uplift. After discussing with @onyb I have marked the main issue as QA/No.

kjozwiak pushed a commit that referenced this pull request Dec 5, 2024
kjozwiak pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropped Solana Transactions Show Continues Loading Panel
4 participants