Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example scripts #43

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Dec 27, 2023

  • Update nitriding command in start.sh to match current argument naming.
  • Replace pkill with kill as pkill is unnecessary and not always available.

Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rillian
Copy link
Contributor

rillian commented Feb 5, 2024

@jalaziz would you mind rebasing? I don't know how to retrigger the hung integration test jobs, but they're required to merge. Pushing a new version might help.

* Update nitriding command in `start.sh` to match current argument
  naming.
* Replace `pkill` with `kill` as `pkill` is unnecessary and not always
  available.
@jalaziz
Copy link
Contributor Author

jalaziz commented Feb 5, 2024

@rillian Rebased!

@rillian rillian merged commit 53210c4 into brave:master Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants