Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize makefile and update README #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mbilloo
Copy link
Contributor

@mbilloo mbilloo commented Jul 13, 2020

This PR attempts to modify the Makefile to make it closer to a proper build system. This has been tested against the breadbee and m5 targets and has been confirmed to generate the appropriate outputs.

Makefile Outdated
OUTPUTS=$(shell realpath $(PWD)/outputs/)
LINUXROOT=$(shell realpath $(PWD)/linux)
LINUX_CONFIG=$(LINUXROOT)/.config
INUX_IMAGE=$(LINUXROOT)/arch/arm/boot/zImage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be LINUX_IMAGE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, yes. I thought I fixed this in my branch.

@mbilloo mbilloo requested a review from fifteenhex July 16, 2020 22:33
@fifteenhex
Copy link
Member

I'll try to look at this today. Finally got some holiday time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants