A complete refactor using promises instead of thunks with other new features and API changes. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "description": "A go style channel implementation that works nicely with co", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "mocha" | |||
| "test": "babel-node --stage=0 node_modules/.bin/blue-tape src/**/*.test.js" | |||
There was a problem hiding this comment.
I was on a kick where I really liked tape when I wrote this, but I am good with sticking with mocha
Closed
src/select.js
Outdated
| @@ -0,0 +1,30 @@ | |||
| import Deferred from './deferred' | |||
|
|
|||
| function pairs () | |||
There was a problem hiding this comment.
oops, shouldn't have commited this line :(, thats what I get for just commiting stuff in a half complete state.
|
@coderhaoxin I have had some time to work on this. I will try to push up some stuff by tomorrow morning. I am updating the dependencies, writing tests, and improving the select functionality. |
existing functionality moved to alts function
|
@coderhaoxin I just pushed up a bunch of stuff, there is still more to be done, but I will try to take some time over the weekend. Let me know if you have any feedback on what I am doing in this branch. |
gitignore: add lib fix entry
including adding type annotations for everything as well as some refactoring/api changes to make it fit better with static types. why typescript? i really like typescript and wanted to al least publish a typescript definition file with the package. it will be much easier to keep in sync if i write the src in typescript as well. it works out really nice for a lot of things. for example: directional channels (similar to golang) can now be acheived and checked at compile time by using specialized directional interface types `InChannel<T>` and `OutChannel<T>`. chan will continue to be just as usable from javascript. updates to the build and tests as well as removal of the old babel dependencies will come in future commits. this is a big enough chunck already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining things to do before merging:
src/(could be based on old test that are not removed yet)prepublishbuild stepasync awaitinstead ofco, with maybe onecospecific example)async.jsin the new codelib/