Comments

brentyi · Dec 18, 2024 · f07374d · f07374d
1 parent 55f0e20
commit f07374d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/tyro/_unsafe_cache.py b/src/tyro/_unsafe_cache.py
@@ -50,6 +50,9 @@ def wrapped_f(*args, **kwargs):
 
 
 def unsafe_hash(obj: Any) -> Any:
+    """We include the types to match functools.
+
+    Some context: https://github.com/brentyi/tyro/issues/214"""
     try:
         return type(obj), hash(obj)
     except TypeError:

diff --git a/tests/test_dcargs.py b/tests/test_dcargs.py
@@ -21,9 +21,8 @@
 )
 
 import pytest
-from typing_extensions import Annotated, Final, Literal, TypeAlias, runtime_checkable
-
 import tyro
+from typing_extensions import Annotated, Final, Literal, TypeAlias, runtime_checkable
 
 
 def test_no_args() -> None:
@@ -957,6 +956,8 @@ class NumericTower:
 
 
 def test_runtime_checkable_edge_case() -> None:
+    """From Kevin Black: https://github.com/brentyi/tyro/issues/214"""
+
     @runtime_checkable
     class DummyProtocol(Protocol):
         pass

diff --git a/tests/test_py311_generated/test_dcargs_generated.py b/tests/test_py311_generated/test_dcargs_generated.py
@@ -960,6 +960,8 @@ class NumericTower:
 
 
 def test_runtime_checkable_edge_case() -> None:
+    """From Kevin Black: https://github.com/brentyi/tyro/issues/214"""
+
     @runtime_checkable
     class DummyProtocol(Protocol):
         pass