Handle required arguments in nested pydantic models #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular example failed on me with
I dug around in the code and realized that this is because of the way that the default values for pydantic fields are retrieved in https://github.com/brentyi/tyro/blob/main/src/tyro/_fields.py#L1186
By wrapping in a ValidationError try-catch, we can check if the specified field did try to initialize but crashed due to lack of constructors for some fields, therefore it is in fact a "required" field