general cleanup #25
Open
general cleanup #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier-figueroa
force-pushed
the
cleanup
branch
2 times, most recently
from
74debc4 to
a1771c2
Compare
xavier-figueroa
force-pushed
the
cleanup
branch
from
a1771c2 to
d053223
Compare
xavier-figueroa
force-pushed
the
cleanup
branch
from
d053223 to
1f16879
Compare
|
@xavier-figueroa Can you resolve the pom.xml conflict? |
|
are you ok changing the source to java 7? |
xavier-figueroa
force-pushed
the
cleanup
branch
from
0c2c33f to
43cda6d
Compare
Conflict has been solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redundant modifiers
remove exceptions that are never thrown
update dependencies that has vulnerabilities
fix some typos
code already uses string methods that are available since java 6, so I had to update java version from 1.5. I think its safe to use java 1.7
it addressess issue #17