1.0.2

* require/amd fix for the console * added support for binding arrays of objects
brewster1134 · Oct 28, 2014 · 00ae97c · 00ae97c
1 parent 8565583
commit 00ae97c
Show file tree

Hide file tree

Showing 14 changed files with 110 additions and 76 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/demo/atrackt_demo.css b/demo/atrackt_demo.css
@@ -17,5 +17,3 @@ a {
   padding: 30px;
   border: 1px solid lightgrey;
   margin-bottom: 30px; }
-
-/*# sourceMappingURL=atrackt_demo.css.map */
diff --git a/lib/atrackt.console.css b/lib/atrackt.console.css
@@ -21,5 +21,3 @@ body.atrackt-console {
       body.atrackt-console #atrackt-console table tr.error {
         color: white;
         background-color: red; }
-
-/*# sourceMappingURL=atrackt.console.css.map */
diff --git a/lib/atrackt.console.js b/lib/atrackt.console.js
diff --git a/lib/atrackt.js b/lib/atrackt.js
diff --git a/lib/plugins/atrackt.localytics.js b/lib/plugins/atrackt.localytics.js
diff --git a/lib/plugins/atrackt.omniture.js b/lib/plugins/atrackt.omniture.js
diff --git a/spec/atrackt_spec.coffee b/spec/atrackt_spec.coffee
@@ -99,6 +99,21 @@ describe 'Atrackt', ->
 
       expect($._data($fooEl[0]).events.click[0].namespace).to.equal 'atrackt'
 
+    it 'should bind an array of all types of objects', ->
+      $selectorOneEl = $('<div class="array-selector-one"></div>')
+      $selectorTwoEl = $('<div class="array-selector-two"></div>')
+      $jqueryEl = $('<div class="array-jquery"></div>')
+      $htmlNodeEl = $('<div class="array-html-node"></div>')
+      $('body').append $selectorOneEl, $selectorTwoEl, $jqueryEl, $htmlNodeEl
+
+      Atrackt.setEvent
+        click: [ '.array-selector-one, .array-selector-two', $('.array-jquery'), $('.array-html-node')[0]]
+
+      expect($._data($selectorOneEl[0]).events.click[0].namespace).to.equal 'atrackt'
+      expect($._data($selectorTwoEl[0]).events.click[0].namespace).to.equal 'atrackt'
+      expect($._data($jqueryEl[0]).events.click[0].namespace).to.equal 'atrackt'
+      expect($._data($htmlNodeEl[0]).events.click[0].namespace).to.equal 'atrackt'
+
   describe '#setOptions', ->
     before ->
       Atrackt.setOptions

diff --git a/src/README.md b/src/README.md
@@ -1,4 +1,11 @@
 ### CHANGE LOG
+###### 1.0.2
+* require/amd fix for the console
+* added support for binding arrays of objects
+
+###### 1.0.0
+* refactor and api updates
+
 ###### 0.1.2
 * Improved compatibility with <IE8
 

diff --git a/src/atrackt.coffee b/src/atrackt.coffee
@@ -1,7 +1,7 @@
 ###
 Atrackt Tracking Library
 https://github.com/brewster1134/atrackt
-@version 1.0.0
+@version 1.0.2
 @author Ryan Brewster
 ###
 
@@ -70,33 +70,38 @@ https://github.com/brewster1134/atrackt
         pluginEvent = globalEvent.slice(0)
         pluginEvent.push context.name if context.name
 
-        $(objects).each (index, element) =>
-          @_elements[eventType] ||= []
-
-          # if binding on a plugin
-          # ...and the element has not already been bound globally
-          # ...and the element has not already been bound to the plugin
-          if context.name
-            globalIndex = @_elements[eventType].indexOf(element)
-
-            # if element is not in global array...
-            if globalIndex == -1
-              context._elements[eventType] ||= []
-
-              # if element is not in plugin array...
-              if context._elements[eventType].indexOf(element) == -1
-                @_registerElement context, element, eventType
-
-          # if binding globally
-          # ...and the element has not already been bound globally
-          else if @_elements[eventType].indexOf(element) == -1
-            @_registerElement context, element, eventType
-
-            # loop through plugins and remove global element if it exists
-            for pluginName, pluginData of @plugins
-              pluginIndex = pluginData._elements[eventType]?.indexOf(element)
-              if pluginIndex != -1
-                pluginData._elements[eventType]?.splice pluginIndex, 1
+        # typecast objects into an array
+        unless objects instanceof Array
+          objects = [objects]
+
+        for object in objects
+          $(object).each (index, element) =>
+            @_elements[eventType] ||= []
+
+            # if binding on a plugin
+            # ...and the element has not already been bound globally
+            # ...and the element has not already been bound to the plugin
+            if context.name
+              globalIndex = @_elements[eventType].indexOf(element)
+
+              # if element is not in global array...
+              if globalIndex == -1
+                context._elements[eventType] ||= []
+
+                # if element is not in plugin array...
+                if context._elements[eventType].indexOf(element) == -1
+                  @_registerElement context, element, eventType
+
+            # if binding globally
+            # ...and the element has not already been bound globally
+            else if @_elements[eventType].indexOf(element) == -1
+              @_registerElement context, element, eventType
+
+              # loop through plugins and remove global element if it exists
+              for pluginName, pluginData of @plugins
+                pluginIndex = pluginData._elements[eventType]?.indexOf(element)
+                if pluginIndex != -1
+                  pluginData._elements[eventType]?.splice pluginIndex, 1
 
     # Set data that will always be tracked
     #

diff --git a/src/atrackt.console.coffee b/src/atrackt.console.coffee
@@ -1,7 +1,7 @@
 ###
 Atrackt Tracking Library
 https://github.com/brewster1134/atrackt
-@version 1.0.0
+@version 1.0.2
 @author Ryan Brewster
 ###
 
@@ -12,7 +12,7 @@ https://github.com/brewster1134/atrackt
         'jquery'
         'atrackt'
       ], ($, Atrackt) ->
-        window.Atrackt = new(factory($, Atrackt))
+        window.Atrackt = new(factory($, Atrackt.constructor))
     else
       window.Atrackt = new(factory($, Atrackt.constructor))
 ) @, ($, Atrackt) ->

diff --git a/src/plugins/README.md b/src/plugins/README.md
@@ -1,5 +1,8 @@
 ### CHANGE LOG
 ##### Localytics Plugin
+###### 1.0.0
+* updated to new api
+
 ###### 0.0.2
 * supports detecting when in UIWebView
 * redirects to a `localytics://` style url for UIWebView
@@ -11,6 +14,9 @@
 * Just a simple send method!
 
 ##### Omniture Plugin
+###### 1.0.0
+* updated to new api
+
 ###### 0.0.7
 * Supports multiple types for tracked values
 

diff --git a/src/plugins/atrackt.localytics.coffee b/src/plugins/atrackt.localytics.coffee
@@ -2,7 +2,7 @@
 Atrackt Localytics Plugin
 https://github.com/brewster1134/atrackt
 @author Ryan Brewster
-@version 1.0.0
+@version 1.0.2
 ###
 
 ((root, factory) ->

diff --git a/src/plugins/atrackt.omniture.coffee b/src/plugins/atrackt.omniture.coffee
@@ -2,7 +2,7 @@
 Atrackt Omniture Plugin
 https://github.com/brewster1134/atrackt
 @author Ryan Brewster
-@version 1.0.0
+@version 1.0.2
 ###
 
 ((root, factory) ->