Fix: Add validation for invalid date query parameter values #3330
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
reviewed
Oct 15, 2024
Comment on lines
+264
to
+272
| var calledDone = false | ||
|
|
||
| client.query(new pg.Query({ text: 'SELECT $1::timestamp', values: [new Date(undefined)] }), function (err, res) { | ||
| if (!calledDone) { | ||
| calledDone = true | ||
| assert.equal(err.message, 'Query parameter value cannot be an invalid date.') | ||
| client.end(done) | ||
| } | ||
| }) |
There was a problem hiding this comment.
The query callback can only be called once (and if it weren’t, we wouldn’t want to silently ignore that):
Suggested change
| var calledDone = false | |
| client.query(new pg.Query({ text: 'SELECT $1::timestamp', values: [new Date(undefined)] }), function (err, res) { | |
| if (!calledDone) { | |
| calledDone = true | |
| assert.equal(err.message, 'Query parameter value cannot be an invalid date.') | |
| client.end(done) | |
| } | |
| }) | |
| client.query(new pg.Query({ text: 'SELECT $1::timestamp', values: [new Date(undefined)] }), function (err, res) { | |
| assert.equal(err.message, 'Query parameter value cannot be an invalid date.') | |
| client.end(done) | |
| }) |
There was a problem hiding this comment.
It will cause this error, as the connection also gets terminated, and the callback will be executed again.
Message: 'Connection terminated' == 'Query parameter value cannot be an invalid date.'
AssertionError [ERR_ASSERTION]: 'Connection terminated' == 'Query parameter value cannot be an invalid date.
There was a problem hiding this comment.
That’s a serious bug, then.
ikonst
reviewed
Nov 25, 2024
| @@ -257,3 +257,18 @@ suite.test('cannot pass non-string values to query as text', (done) => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| if (!helper.args.native) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #3318
Issue Description:
Currently, new Date(undefined) (an invalid date) is serialized as "0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN". It should fail early with a JS error instead of being passed to the database.