fix(terraform): prevent side effects when updating variable rendering (…

…#6087) * fix(terraform): prevent side effects when updating variable rendering * keep the structure --------- Co-authored-by: Steve Vaknin <[email protected]>
bridgecrewio · Mar 14, 2024 · db8fb18 · db8fb18
1 parent 3c855bd
commit db8fb18
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/checkov/terraform/graph_builder/local_graph.py b/checkov/terraform/graph_builder/local_graph.py
@@ -729,15 +729,16 @@ def update_list_attribute(
 
     if len(key_parts) == 1:
         idx = force_int(key_parts[0])
-        inner_config = config[0]
+        # Avoid changing the config and cause side effects
+        inner_config = pickle_deepcopy(config[0])
 
         if idx is not None and isinstance(inner_config, list):
             if not inner_config:
                 # happens when config = [[]]
                 return config
 
             inner_config[idx] = new_value
-            return config
+            return [inner_config]
     entry_to_update = int(key_parts[0]) if key_parts[0].isnumeric() else -1
     for i, config_value in enumerate(config):
         if entry_to_update == -1: