Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Replaced / with os.pathsep to support windows better in terraform runner #5473

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix(terraform): Replaced / with os.pathsep to support windows better in terraform runner #5473

merged 2 commits into from
Aug 22, 2023

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Aug 22, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Replaced / with os.pathsep to support windows better in terraform runner

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 temporarily deployed to scan-security August 22, 2023 11:54 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@bo156 bo156 merged commit c1799eb into main Aug 22, 2023
@bo156 bo156 deleted the bugfix/tf-windows-path-support branch August 22, 2023 13:37
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Aug 22, 2023
@bo156 @actions-user
fix(terraform): Replaced / with os.pathsep to support windows better …
8639fc6 
…in terraform runner (bridgecrewio#5473)

* Replaced / with os.pathsep to support windows better in terraform runner

* Used os.sep instead of os.pathsep which is the correct one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bo156 @gruebel @ChanochShayner