-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secrets): handle non iac secrets FP #5478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxamel
had a problem deploying
to
scan-security
August 23, 2023 09:22 — with
GitHub Actions
Failure
YaaraVerner
approved these changes
Aug 23, 2023
Comment on lines
181
to
192
if detected_secret.secret_value: | ||
# Found keyword prefix as potential secret | ||
if formatted_line.startswith(detected_secret.secret_value): | ||
secrets_to_remove.add(detected_secret) | ||
# found a function name at the end of the line | ||
if formatted_line and FUNCTION_CALL_AFTER_KEYWORD_REGEX.search(formatted_line): | ||
secrets_to_remove.add(detected_secret) | ||
# secret value is substring of keywork | ||
if is_code_file and FOLLOWED_BY_EQUAL_VALUE_KEYWORD_REGEX.search(formatted_line): | ||
key, value = line.split("=", 1) | ||
if detected_secret.secret_value in key and detected_secret.secret_value in value: | ||
secrets_to_remove.add(detected_secret) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if detected_secret.secret_value: | |
# Found keyword prefix as potential secret | |
if formatted_line.startswith(detected_secret.secret_value): | |
secrets_to_remove.add(detected_secret) | |
# found a function name at the end of the line | |
if formatted_line and FUNCTION_CALL_AFTER_KEYWORD_REGEX.search(formatted_line): | |
secrets_to_remove.add(detected_secret) | |
# secret value is substring of keywork | |
if is_code_file and FOLLOWED_BY_EQUAL_VALUE_KEYWORD_REGEX.search(formatted_line): | |
key, value = line.split("=", 1) | |
if detected_secret.secret_value in key and detected_secret.secret_value in value: | |
secrets_to_remove.add(detected_secret) | |
if not detected_secret.secret_value: | |
continue | |
# Found keyword prefix as potential secret | |
if formatted_line.startswith(detected_secret.secret_value): | |
secrets_to_remove.add(detected_secret) | |
# found a function name at the end of the line | |
if formatted_line and FUNCTION_CALL_AFTER_KEYWORD_REGEX.search(formatted_line): | |
secrets_to_remove.add(detected_secret) | |
# secret value is substring of keywork | |
if is_code_file and FOLLOWED_BY_EQUAL_VALUE_KEYWORD_REGEX.search(formatted_line): | |
key, value = line.split("=", 1) | |
if detected_secret.secret_value in key and detected_secret.secret_value in value: | |
secrets_to_remove.add(detected_secret) |
bo156
approved these changes
Aug 23, 2023
SKisContent
pushed a commit
to SKisContent/checkov
that referenced
this pull request
Aug 23, 2023
* handle non iac secrets FP * fix mypy issue * fix according to comments --------- Co-authored-by: Max Amelchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to filter out FPs in non-iac files for cases where secrets are not compatible with Base64 Entropy case