Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(terraform): fix in subgraphs uploads #5610

Merged
merged 4 commits into from
Oct 2, 2023
Merged

platform(terraform): fix in subgraphs uploads #5610

merged 4 commits into from
Oct 2, 2023

Conversation

YaaraVerner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

convert the subgraph path to None if not exist

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@YaaraVerner YaaraVerner temporarily deployed to scan-security October 2, 2023 08:47 — with GitHub Actions Inactive
@YaaraVerner YaaraVerner changed the title platform(terraform) fix in subgraphs uploads platform(terraform): fix in subgraphs uploads Oct 2, 2023
@YaaraVerner YaaraVerner temporarily deployed to scan-security October 2, 2023 09:01 — with GitHub Actions Inactive
@YaaraVerner YaaraVerner marked this pull request as ready for review October 2, 2023 09:06
@YaaraVerner YaaraVerner merged commit f19727c into main Oct 2, 2023
30 checks passed
@YaaraVerner YaaraVerner deleted the fix-in-subrgaphs-upload branch October 2, 2023 09:08
pull bot pushed a commit to tooniez/checkov that referenced this pull request Oct 2, 2023
@YaaraVerner @actions-user
platform(terraform): fix in subgraphs uploads (bridgecrewio#5610)
bbd182c 
* convert subgraph path to None if not exist

* revert changes in wrapper

* fix mypy

* fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaaraVerner @lirshindalman @ChanochShayner