Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace policyuniverse with policy-sentry equivalent #5640

Merged
merged 4 commits into from
Oct 23, 2023
Merged

chore: replace policyuniverse with policy-sentry equivalent #5640

merged 4 commits into from
Oct 23, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 12, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • replaced policyuniverse with policy-sentry equivalent, therefore no need for the dependency anymore 🍻
  • and it is roughly double as fast 🚗

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security October 12, 2023 22:12 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 12, 2023 22:31 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 23, 2023 11:14 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 23, 2023 11:28 — with GitHub Actions Inactive
@gruebel gruebel merged commit fd2697c into bridgecrewio:main Oct 23, 2023
29 checks passed
@gruebel gruebel deleted the replace-policyunivers branch October 23, 2023 12:13
pull bot pushed a commit to tooniez/checkov that referenced this pull request Oct 23, 2023
@gruebel @actions-user
chore: replace policyuniverse with policy-sentry equivalent (bridgecr…
6055c76 
…ewio#5640)

* replace policyuniverse with policy-sentry equivalent

* fix test and typing

* migrate CKV_AWS_32

* fix typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruebel @lirshindalman @ChanochShayner