Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break(general): remove multi_signature and adjust base check classes #5645

Merged
merged 2 commits into from
Oct 24, 2023
Merged

break(general): remove multi_signature and adjust base check classes #5645

merged 2 commits into from
Oct 24, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 14, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • removed multi_signature file
  • streamlined all base check classes to use the proper method signature

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security October 14, 2023 21:29 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 14, 2023 21:37 — with GitHub Actions Inactive
@gruebel gruebel marked this pull request as ready for review October 20, 2023 12:50
@gruebel gruebel merged commit 0df8ed8 into bridgecrewio:main Oct 24, 2023
29 checks passed
@gruebel gruebel deleted the remove-multi-signature branch October 24, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruebel @tronxd @ChanochShayner