Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(general): Add SAST enforcement rules and check severity thresholds #5684

Merged
merged 4 commits into from
Oct 25, 2023
Merged

platform(general): Add SAST enforcement rules and check severity thresholds #5684

merged 4 commits into from
Oct 25, 2023

Conversation

mikeurbanski1
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds logic to pass severity thresholds from --check / --skip-check and enforcement rules (soft fail level) to sast-core for policy filtering.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mikeurbanski1 mikeurbanski1 temporarily deployed to scan-security October 24, 2023 21:31 — with GitHub Actions Inactive
@gruebel gruebel merged commit 8ef0b63 into main Oct 25, 2023
29 of 33 checks passed
@gruebel gruebel deleted the sast-enf-rules branch October 25, 2023 12:25
arielkru pushed a commit that referenced this pull request Oct 25, 2023
@mikeurbanski1 @actions-user
platform(general): Add SAST enforcement rules and check severity thre…
2c8fcc7 
…sholds (#5684)

* pass check and skip check severity thresholds to sast core

* add test for get_check_thresholds

* fix mypy issues

* fix mypy issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeurbanski1 @tronxd @gruebel