Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(general): Fix sast & cdk integration tests #5688

Merged
merged 10 commits into from
Oct 26, 2023
Merged

fix(general): Fix sast & cdk integration tests #5688

merged 10 commits into from
Oct 26, 2023

Conversation

arielkru
Copy link
Contributor

@arielkru arielkru commented Oct 25, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Fix cdk tests
  • Fix sast report validation (pydantic)
  • Unskip js test
  • Skip (temporarily) java test - too heavy repo @gruebel is looking for another one
  • Remove irrelevant sast checks dir

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@arielkru arielkru temporarily deployed to scan-security October 25, 2023 16:39 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@gruebel gruebel temporarily deployed to scan-security October 25, 2023 22:08 — with GitHub Actions Inactive
@arielkru arielkru temporarily deployed to scan-security October 26, 2023 07:17 — with GitHub Actions Inactive
@arielkru arielkru merged commit edcb5ca into main Oct 26, 2023
37 checks passed
@arielkru arielkru deleted the fix_integration_tests branch October 26, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemavni rotemavni rotemavni approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arielkru @gruebel @rotemavni