Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Adding both azurerm_linux_web_app_slot & azurerm_windows_web_app_slot in scope of the test CKV_AZURE_154 #5693

Closed
wants to merge 8 commits into from

Conversation

tdefise
Copy link
Contributor

@tdefise tdefise commented Oct 26, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5692

New/Edited policies (Delete if not relevant)

Description

Same as for azurerm_app_service_slot

Fix

Same as for azurerm_app_service_slot

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • [] New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tdefise tdefise temporarily deployed to scan-security October 26, 2023 13:10 — with GitHub Actions Inactive
@tdefise
Copy link
Contributor Author

tdefise commented Nov 8, 2023

Hi @gruebel,

I guess "test_app_service_windows_web_resources" needs to be changed

@gruebel
Copy link
Contributor

gruebel commented Nov 8, 2023

😅 yes, sorry for that

Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @gruebel 's review, looks good to me 👍 Let's fix the relevant test/issue, leaving for @gruebel to give the final approval

@tdefise tdefise closed this by deleting the head repository Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV_AZURE_154 - Not available for linux_web_app_slot & azurerm_windows_web_app_slot
3 participants