Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sast): adjust SAST file pattern search #5694

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix(sast): adjust SAST file pattern search #5694

merged 2 commits into from
Oct 26, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 26, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • the regex never found anything, because re.match looks from the beginning of the string

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security October 26, 2023 11:47 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 26, 2023 13:00 — with GitHub Actions Inactive
@gruebel gruebel merged commit 3ec90e7 into main Oct 26, 2023
37 checks passed
@gruebel gruebel deleted the fix-sast-regex branch October 26, 2023 13:37
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Oct 26, 2023
@gruebel @actions-user
fix(sast): adjust SAST file pattern search (bridgecrewio#5694)
b8ea491 
* adjust SAST file pattern search

* extract SAST core filename to separate pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkru arielkru arielkru approved these changes

@rotemavni rotemavni rotemavni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruebel @rotemavni @arielkru