Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): fix variable rendering for foreach resources with dot included names #5701

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 29, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • added a function to join back strings, which were split by a dot and wrongfully applied to dots inside a quoted string, this is happens mainly to a for_each resource key google_project_iam_binding.role["roles/logging.admin"] and results in failing to correctly propagate rendered variables
  • I tried it with regex, but couldn't find one, which would do the job for me, so if anyone has a good idea to tackle it more elegant, feel free 🍻

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security October 29, 2023 08:50 — with GitHub Actions Inactive
Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gruebel gruebel merged commit c651ff2 into bridgecrewio:main Oct 30, 2023
37 checks passed
@gruebel gruebel deleted the fix-foreach-tfvars branch October 30, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants