Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sca): Extending reachability post-runner in checkov and enriching cves with ReachableFunction data #5707

Merged
merged 8 commits into from
Nov 1, 2023
Merged

feat(sca): Extending reachability post-runner in checkov and enriching cves with ReachableFunction data #5707

merged 8 commits into from
Nov 1, 2023

Conversation

itai1357
Copy link
Contributor

@itai1357 itai1357 commented Nov 1, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Extending reachability post-runner in checkov and enriching cves with 'reachable function' data
  • creating UTs for the new feature

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@itai1357 itai1357 changed the title feat(sca): Extending reachability post-runner in checkov and enriching cves with 'reachable function' data feat(sca) Extending reachability post-runner in checkov and enriching cves with 'reachable function' data Nov 1, 2023
@itai1357 itai1357 changed the title feat(sca) Extending reachability post-runner in checkov and enriching cves with 'reachable function' data feat(sca): Extending reachability post-runner in checkov and enriching cves with ReachableFunction data Nov 1, 2023
NoaAzoulay
NoaAzoulay approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@NoaAzoulay NoaAzoulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Saarett
Saarett approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@itai1357 itai1357 merged commit 6d0d3b9 into main Nov 1, 2023
33 of 34 checks passed
@itai1357 itai1357 deleted the itai_enrich_cves_with_reachable_function_data branch November 1, 2023 10:38
gruebel pushed a commit that referenced this pull request Nov 1, 2023
@itai1357 @actions-user
feat(sca): Extending reachability post-runner in checkov and enrichin…
c6ebb34 
…g cves with ReachableFunction data (#5707)

* creating the _is_reachable_function_for_cve

* remove unused

* add tests

* fix types

* fix mypi

* remove

* remove

* remove

---------

Co-authored-by: ipeleg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoaAzoulay NoaAzoulay NoaAzoulay approved these changes

@Saarett Saarett Saarett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itai1357 @Saarett @NoaAzoulay