Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable mypy for kubernetes.checks #5722

Merged
merged 2 commits into from
Nov 6, 2023
Merged

chore: enable mypy for kubernetes.checks #5722

merged 2 commits into from
Nov 6, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Nov 4, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • enable mypy for kubernetes.checks
  • add stubs for docker package

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit b50514c into bridgecrewio:main Nov 6, 2023
37 checks passed
@gruebel gruebel deleted the enable-mypy-k8s branch November 6, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveVaknin SteveVaknin SteveVaknin approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruebel @ChanochShayner @SteveVaknin