Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): add FunctionAppDisallowCORS - password correctness check #6248

Merged
merged 11 commits into from
May 19, 2024

Conversation

unu87
Copy link
Contributor

@unu87 unu87 commented May 5, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

This code defines an Azure security check to prevent Function Apps from allowing access from all regions by inspecting the CORS configuration.

Fixes # (issue)
The issue can be fixed by explicitly specifying allowed origins instead of using "*" in the CORS configuration.

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner self-requested a review May 5, 2024 19:19
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 💯

@unu87 unu87 temporarily deployed to scan-security May 7, 2024 10:47 — with GitHub Actions Inactive
@ChanochShayner ChanochShayner merged commit 9b6feb1 into bridgecrewio:main May 19, 2024
41 checks passed
@ChanochShayner ChanochShayner self-assigned this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants