Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudformation): Add sensitive param check #6921

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Dec 23, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds check for sensitive values in SSM param and

Fixes #6700
Fixes #6917

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Adds a new check for sensitive values in AWS Systems Manager (SSM) Parameter Store and enhances the existing Lambda environment credentials check. Implements a new class ParameterStoreCredentials to scan for hard-coded secrets in SSM Parameter values. Updates the LambdaEnvironmentCredentials check to skip values starting with 'handler.' or 'git.'. Extends the secret detection patterns in the secrets.py file to include password-specific patterns. Adds corresponding test cases for both new and updated checks.

TopicDetails
SSM Param Check Implements a new check for detecting hard-coded secrets in AWS SSM Parameter Store values
Modified files (3)
  • checkov/cloudformation/checks/resource/aws/ParameterStoreCredentials.py
  • tests/cloudformation/checks/resource/aws/example_ParameterStoreCredentials/mix.yaml
  • tests/cloudformation/checks/resource/aws/test_ParameterStoreCredentials.py
Latest Contributors(0)
UserCommitDate
Lambda Cred Check Enhances the Lambda environment credentials check to ignore 'handler.' and 'git.' prefixed values
Modified files (4)
  • tests/cloudformation/checks/resource/aws/example_LambdaEnvironmentCredentials/PASS3.yaml
  • tests/cloudformation/checks/resource/aws/example_LambdaEnvironmentCredentials/PASS2.yaml
  • checkov/cloudformation/checks/resource/aws/LambdaEnvironmentCredentials.py
  • tests/cloudformation/checks/resource/aws/test_LambdaEnvironmentCredentials.py
Latest Contributors(2)
UserCommitDate
manuchandrasekhar@gmai...fix-terraform-and-cdk-...January 28, 2024
gruebelfix-cloudformation-ign...November 12, 2023
Secret Detection Extends secret detection patterns to include password-specific patterns and improves performance
Modified files (1)
  • checkov/common/util/secrets.py
Latest Contributors(2)
UserCommitDate
bo156feat-secrets-used-10-c...December 07, 2023
gruebelfix-cloudformation-ign...November 12, 2023
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 deployed to scan-security December 23, 2024 17:28 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant