Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): add proxy to git clone from #6923

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Dec 24, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Adds proxy support for git clone operations and refactors proxy-related functionality. Introduces a new function get_proxy_envs() to handle proxy environment variables. Updates the ProxyClient class to use environment variables from env_vars_config. Moves the call_http_request_with_proxy function to a more centralized location.

TopicDetails
Proxy Git Clone Adds proxy support to git clone operations in the _clone method of the BaseGetter class
Modified files (2)
  • checkov/common/proxy/proxy_client.py
  • checkov/common/goget/github/get_git.py
Latest Contributors(2)
UserCommitDate
bo156feat-general-Add-resou...July 19, 2023
omryMenfeat-github-Add-abilit...July 17, 2023
Proxy Refactoring Refactors proxy-related functionality and centralizes proxy handling
Modified files (3)
  • checkov/common/proxy/proxy_client.py
  • checkov/common/proxy/__init__.py
  • checkov/terraform/module_loading/loaders/registry_loader.py
Latest Contributors(2)
UserCommitDate
apgruczafix-terraform-Unable-t...June 04, 2023
gruebelchore-add-type-hints-t...May 23, 2023
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

checkov/common/proxy/proxy_client.py Outdated Show resolved Hide resolved
checkov/common/proxy/proxy_client.py Show resolved Hide resolved
checkov/common/proxy/proxy_client.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants