small fix is_prefixed_with_dollar_sign (#226)

bridgecrewio · Nov 10, 2024 · ce9c167 · ce9c167
1 parent 17a8f44
commit ce9c167
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/detect_secrets/filters/heuristic.py b/detect_secrets/filters/heuristic.py
@@ -162,7 +162,9 @@ def is_prefixed_with_dollar_sign(secret: str) -> bool:
     # false negatives than `is_templated_secret` (e.g. secrets that actually start with a $).
     # This is best used with files that actually use this as a means of referencing variables.
     # TODO: More intelligent filetype handling?
-    return secret[0] == '$'
+    if len(secret) > 0 and secret[0] == '$':
+        return True
+    return False
 
 
 def is_indirect_reference(line: str) -> bool:

diff --git a/tests/filters/heuristic_filter_test.py b/tests/filters/heuristic_filter_test.py
@@ -124,6 +124,7 @@ def test_is_templated_secret(line, result):
 def test_is_prefixed_with_dollar_sign():
     assert filters.heuristic.is_prefixed_with_dollar_sign('$secret')
     assert not filters.heuristic.is_prefixed_with_dollar_sign('secret')
+    assert not filters.heuristic.is_prefixed_with_dollar_sign('')
 
 
 @pytest.mark.parametrize(