Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureStorageKeyDetector scan multi lines and skip public keys #178

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

anatolii-paloaltonetworks
Copy link

@anatolii-paloaltonetworks anatolii-paloaltonetworks commented Jan 22, 2024

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?
    Update azure_storage_key plugin to skip public keys and scan multiline if key and value are located in different lines

  • What is the current behavior?

detected secret in public key (single line)

SshPublicKeys: ssh-rsa lJzRc1YdHaAA2KCNJJ1tkYwF/+mKK6Ygw0NGe170Xu592euJv2wYUtBlV8z+qnlcNQSnIYVTkLWntUO1F8j8rQ=="

detected secret in public key (multi line)

SshPublicKeys: 
- >-
ssh-rsa lJzRc1YdHaAA2KCNJJ1tkYwF/+mKK6Ygw0NGe170Xu592euJv2wYUtBlV8z+qnlcNQSnIYVTkLWntUO1F8j8rQ=="
  • What is the new behavior (if this is a feature change)?

NOT detected secret in public key (single line)

SshPublicKeys: ssh-rsa lJzRc1YdHaAA2KCNJJ1tkYwF/+mKK6Ygw0NGe170Xu592euJv2wYUtBlV8z+qnlcNQSnIYVTkLWntUO1F8j8rQ=="

NOT detected secret in public key (multi line)

SshPublicKeys: 
- >-
ssh-rsa lJzRc1YdHaAA2KCNJJ1tkYwF/+mKK6Ygw0NGe170Xu592euJv2wYUtBlV8z+qnlcNQSnIYVTkLWntUO1F8j8rQ=="
  • Does this PR introduce a breaking change?
    nothing

  • Other information:

@anatolii-paloaltonetworks anatolii-paloaltonetworks changed the title BCE-24998 scan multi lines and skip public keys AzureStorageKeyDetector scan multi lines and skip public keys Jan 23, 2024
@bo156 bo156 merged commit 66b84b4 into master Jan 23, 2024
17 checks passed
@bo156 bo156 deleted the skip-public-keys branch January 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants