Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csvmum] handle int and float64 pointers #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[csvmum] handle int and float64 pointers #15

wants to merge 5 commits into from

Conversation

SeannyPhoenix
Copy link
Collaborator

Marshal and unmarshal *int and *float64 fields.

@SeannyPhoenix SeannyPhoenix added the csvmum CSV Marshaling and Unmarshaling label Dec 21, 2024
@SeannyPhoenix SeannyPhoenix linked an issue Dec 21, 2024 that may be closed by this pull request
[csvmum] Handle int and float64 pointers #14
Open
@SeannyPhoenix SeannyPhoenix changed the title handle int and float64 pointers [csvmum] handle int and float64 pointers Dec 21, 2024
amadigan
amadigan reviewed Dec 21, 2024
View reviewed changes
pkg/csvmum/unmarshal.go Outdated
case reflect.Pointer:
switch f.Type().Elem().Kind() {
case reflect.Int:
if i, err := strconv.Atoi(r[i]); err == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like parse errors that won't be reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amadigan amadigan amadigan left review comments

Assignees
No one assigned
Labels
csvmum CSV Marshaling and Unmarshaling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[csvmum] Handle int and float64 pointers
2 participants
@SeannyPhoenix @amadigan