-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add alert component #34
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: abdo-coder <[email protected]>
@coder-abdo PR seems to have a lot of unrelated changes in it. |
I just add two lines of code, the |
@coder-abdo you may want to double-check that. Maybe your editor is automatically reformatting files somehow when you save? There are a lot of changes in this PR, including the order of important statements, the addition of semicolons to the end of evey statement, and more. |
I am using |
@coder-abdo the standards we're following currently are consistent with what we've followed elsewhere in the Brigade project. In other places we have a linter incorporated into our CI to validate that PRs adhere to those standards. It's something I'll have in place here as well within the coming week. If you don't like the standards we currently follow, start a separate discussion about that in its own issue and be clear about what you're proposing and why it's better, and we can have that discussion there. It's usually bad form to bundle sweeping changes to a project's coding standards into a small, discrete change like this one. |
what should I do to lint and format my code now? |
@coder-abdo I've just opened #37 to automate linting as part of CI. |
@coder-abdo are you able to rebase this on the latest from the main branch? |
Signed-off-by: abdo-coder [email protected]