Feature note component #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow more flexibility to users when writing a note - Define min-height
- Update label text - Match label for="" value with unique textarea id=""
- Add missing copies - Use single quote instead of double quote on translation files
Use inset on type="radio" causes issues on Firefox Due to that I'm forcing width and height manualy
Just to make it easy in case we need to use HEX values instead of HSL
This was referenced Jun 26, 2024
|
I did a quick manual test and found some critical bugs 😞 Auto resize note on long text stringsnote-resize.mp4Resize note issueslong-text-string-resize.mp4note-resize-2.mp4Select element issues after resizeresize-select-issues.mp4 |
| @@ -566,6 +572,7 @@ const controller = function (ModelAPI, $stateParams, $rootScope, $timeout, $uibM | |||
| if(error.status == 404 || error.status == 401) { | |||
| $state.go("noaccess"); | |||
| } | |||
| console.log(error); | |||
Comment on lines
+150
to
+165
| case "Entity-Entity": | ||
| this.connectEntities(source, target, link); | ||
| break; | ||
| case "Entity-Relationship": | ||
| this.connectEntityRelationship(target, link); | ||
| break; | ||
| case "Entity-Extension": | ||
| console.log(`conecting Entity-Extension`); | ||
| break; | ||
| case "Entity-Attribute": | ||
| console.log(`conecting Entity-Attribute`); | ||
| break; | ||
| case "Attribute-Attribute": | ||
| this.connectAttributeAttribute(source, target); | ||
| break; | ||
| case "Note-Any": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #433
closes: #369
closes: #457