-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD-2803: Fixing Optimus h5ad generation to handle gene_ids more flexibly #1431
Open
ekiernan
wants to merge
8
commits into
develop
Choose a base branch
from
lk-PD-2803-fix-refseq-h5ad
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remember to squash merge! |
1 similar comment
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the warp-tools docker for Optimus; this docker contains updated scripts for building the h5ad file. The script adds a more flexible search gene_name and gene_id to enable processing with refseq GTFs like those used for BICAN macaque and marmoset data processing. This should produce an h5ad file that has the appropriate gene_ids in the anndata.var.index.