refactor: year chart

[eldu]

• refactor: YearChart.js and yearChart.json
  • Now when a year is clicked, it's just highlighted

TODOs that came from this PR

• Filter pubs table by selected year from year chart #70
  • 🚧 Waiting on doing this functionality until after Upgrade react table to tanstack #51
• Fix: Dataset missing values and other issues #71
  • YES, the year chart looks weird because there are publications with missing data!!! I plan to fix this on the data side, not on this side.

Demo

Untitled.mov

Old
Screenshot 2024-02-27 at 3 50 49 PM
Screenshot 2024-02-27 at 3 50 44 PM

[github-actions]

Visit the preview URL for this PR (updated for commit 18249c1):

https://ccv-pubs--pr69-refactor-year-chart-r2hr8d1z.web.app

_{(expires Fri, 08 Mar 2024 21:16:30 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f75c16b3bdd7d81b7a0b7f8d3eed826b541e7a2a}

[hetd54]

This looks so cool! You've done a beautiful job.

I think the month view shows the same data no matter which month you are on currently. 2024 shows 3 pubs:

But the Month view for 2024 is showing:

It was also unclear to me as a user how to return to the year view. Should we add something visually instead of clicking on the table again?

[eldu]

@hetd54 Amazing catch! Somehow through my refactor I messed up the filter. Here's what 2024 looks like now :)

It was also unclear to me as a user how to return to the year view. Should we add something visually instead of clicking on the table again?

So, this is what the previous functionality was. I'm interested into hearing ideas though !

[hetd54]

@hetd54 Amazing catch! Somehow through my refactor I messed up the filter. Here's what 2024 looks like now :)

> It was also unclear to me as a user how to return to the year view. Should we add something visually instead of clicking on the table again?

So, this is what the previous functionality was. I'm interested into hearing ideas though !

Data looks as expected now!

For an idea, maybe a " ← Back to Year View" link somewhere beneath the title, or even below the graph? That way you can reserve the action of clicking on the bar for the table filter feature later.

[eldu]

• Remove month view
• Highlight selectedYear

[hetd54]

@eldu I would expect that clicking on a bar to highlight it instantly, but if a bar is already highlighted it unhighlights onclick no matter where on the graph you've clicked:

Screen.Recording.2024-02-29.at.10.57.54.AM.mov