-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for class methods named "static" #15
Conversation
build script is still broken (see #14 ) However, this patch seems to have introduced a regression with class private fields? not sure why |
can reproduce the regression by switching between the two parser extensions here const acorn = require("acorn")
const Parser = acorn.Parser.extend(require("acorn-static-class-features"))
// const Parser = acorn.Parser.extend(require("./lib/static-class-features"))
const result = Parser.parse("class X { static #x = y }", { ecmaVersion: 10 }) |
narrowed it down to |
oof ok, solved it |
here is an issue for buble relating to us needing to do the manual fix at all bublejs/buble#259 |
btw there's in range updates for the following, and the dynamic import thing should be figured out, but out of scope for this issue
|
We should def switch to Babel, I liked Bublé's smallness but AFAIK it's not actively maintained now and we're already having to pile up hacks to make the build work 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna do the babel switch separately. Thanks for the PR!
@goto-bus-stop thanks/ would really appreciate a patch version today if possible 🙏 |
@goto-bus-stop sorry to bother, i would really appreciate if you could publish a patch ✨ |
status: ready 🎉
Fixes #13
Fixes #14
encountered this parsing
fast-glob
viamdeps
usingresolve
@goto-bus-stop @ljharb