Add new tests for Helper::destroy and Helper::id(true).

Downgrade phpunit on version 4.7 (in 4.8 is broken "@runInSeparateProcess").
bryanjhv · Feb 26, 2017 · 61c47b3 · 61c47b3
1 parent 5d53314
commit 61c47b3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -26,7 +26,7 @@
     "slim/slim": "^3.0"
   },
   "require-dev": {
-    "phpunit/phpunit": "^4.8"
+    "phpunit/phpunit": "4.7.*"
   },
   "autoload": {
     "psr-4": {

diff --git a/tests/HelperTest.php b/tests/HelperTest.php
@@ -88,17 +88,37 @@ public function testClear()
         $this->assertEmpty($_SESSION);
     }
 
+    /**
+     * @runInSeparateProcess
+     */
     public function testId()
     {
         $helper = new Helper();
 
         $this->assertSame(session_id(), $helper::id());
-        $this->markTestIncomplete('Please implement check for "::id(true)"');
+        $this->assertNotSame(session_id(), $sessionId = $helper::id(true));
+        $this->assertSame(session_id(), $sessionId);
     }
 
+    /**
+     * @runInSeparateProcess
+     */
     public function testDestroy()
     {
-        $this->markTestIncomplete('Please implement check for "::destroy"');
+        $helper = new Helper();
+
+        $_SESSION = ['a' => 'A', 'b' => 'B', 'c' => 'C'];
+
+        $this->assertNotEmpty($helper::id());
+        $this->assertNotEmpty(session_id());
+        $this->assertNotEmpty($_SESSION);
+
+        $helper::destroy();
+
+        $this->assertEmpty(session_id());
+        $this->assertEmpty($_SESSION);
+
+        $this->markTestIncomplete('Please finish test for "::destroy".');
     }
 
     public function testCount()