Skip to content

Commit

Permalink
Added a ToDo for issue #24
Browse files Browse the repository at this point in the history
  • Loading branch information
HerManNav committed Sep 16, 2022
1 parent c0f629a commit bbabb49
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pypickup/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def parseScriptArguments(self, args: argparse.ArgumentParser):
self.packageName = args.packageName
self.pypiLocalPath = args.pypiLocalPath

# ToDo: these are optional params. This must not be parsed in this generic method, but passed as a parameter to the main method of each command.
self.onlySources = args.onlySources
self.includeDevs = args.includeDevs
self.includeRCs = args.includeRCs
Expand Down Expand Up @@ -341,7 +342,6 @@ def synchronizeWithRemote(self):

pypiRemoteIndexFiltered: str = self._htmlManager.filterInHTML(pypiRemoteIndexStr, self._regexZIPAndTars)

# ToDo: fix the bug happening if the local repo hast the wheels&src but the update method has enabled the -s option which means we only want the source. the warning message would not apply yet
remoteIndexHRefs: Dict[str, str] = self._htmlManager.getHRefsList(pypiRemoteIndexFiltered)
localIndexHRefs: Dict[str, str] = self._htmlManager.getHRefsList(pypiLocalIndex)
newPackagesToDownload: Dict[str, str] = self.__getNewPackagesInRemote(remoteIndexHRefs, localIndexHRefs)
Expand Down

0 comments on commit bbabb49

Please sign in to comment.