Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make solid and shell constructors #157

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

DSchroer
Copy link
Contributor

@DSchroer DSchroer commented Dec 5, 2023

Using the shape constructed from a Triangulation. Its possible to build and shell and solid via the TopoDS_Builder API and use it as a full BRep object.

@bschwind
Copy link
Owner

Hey @DSchroer, sorry for the delay on this one, work got busy last week.

Can I get more context on these additions? It might be interesting to add example code that demonstrates what you're using these APIs for. Seems like you're creating OpenCascade Shells and Shapes from a triangle mesh?

@DSchroer
Copy link
Contributor Author

Yeah. The use of this is to build up a TopoDS_Shape from a set of triangle faces. Essentially import an STL and build a usable shape for modeling.

@bschwind
Copy link
Owner

Essentially import an STL and build a usable shape for modeling

Interesting! Does it try to extract features like cylindrical drill holes and such, or does it just treat every polygon edge as a TopoDS_Edge? Something in between?

@DSchroer
Copy link
Contributor Author

Does it try to extract features like cylindrical drill holes and such, or does it just treat every polygon edge as a TopoDS_Edge?

It just builds a mesh out of a bunch of triangular faces. So nothing fancy but it at least allows a bit of interop between existing models and the BREP world.

Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@bschwind bschwind merged commit ccdd197 into bschwind:main Jan 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants