Allow specifying alternate bin and cache directories when downloading #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlavin
commented
May 18, 2023
| cdnUrl: string; | ||
| cdnPath: string; | ||
| ignoreCache: boolean; | ||
| cafilePath?: string; |
There was a problem hiding this comment.
The only new addition are the last two lines. The other lines are made optional to reflect reality.
mdlavin
commented
May 18, 2023
| @@ -203,7 +203,7 @@ declare module "ngrok" { | |||
|
|
|||
| interface CapturedRequestOptions { | |||
| limit: number; | |||
| tunnel_name: string; | |||
| tunnel_name?: string; | |||
There was a problem hiding this comment.
Noticed during development, the tunnnel_name isn't really required
|
P.S. Thank you for working on this project. We've been using it for a while and it works great! |
|
@philnash would you mind considering this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using ngrok inside a Lambda function and in that environment, writing to the node_modules directory is not allowed. Instead, I've been using this patch so that I can store download cache and binaries in the temp directory of the OS.
Rather than making the temp directory use explicit, I thought making it configurable would be better