super relies on name of base class

[kumavis]

class Base { xyz () {} }
const Enhanced = enhance(Base)
const inst = new Enhanced()

inst.xyz()

function enhance (Klass) {
  Klass = class extends Klass {
    xyz () {
      super.xyz()
    }
  }
  return Klass
}

$ cat abc.js | node

$ npx buble abc.js | node
[stdin]:20
    Klass.prototype.xyz = function xyz () {
                                       ^

RangeError: Maximum call stack size exceeded
    at Klass.xyz ([stdin]:20:40)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)
    at Klass.xyz ([stdin]:21:27)

[kumavis]

this pattern can be found in this acorn plugin

which is run under buble in acorn-node. it has a manual workaround for this case.

[kumavis]

transpiled output

var Base = function Base () {};

Base.prototype.xyz = function xyz () {};
var Enhanced = enhance(Base)
var inst = new Enhanced()

inst.xyz()

function enhance (Klass) {
  Klass = /*@__PURE__*/(function (Klass$1) {
    function Klass () {
      Klass$1.apply(this, arguments);
    }

    if ( Klass$1 ) Klass.__proto__ = Klass$1;
    Klass.prototype = Object.create( Klass$1 && Klass$1.prototype );
    Klass.prototype.constructor = Klass;

    Klass.prototype.xyz = function xyz () {
      Klass.prototype.xyz.call(this)
    };

    return Klass;
  }(Klass))
  return Klass
}

the super.xyz() call is rendered as

Klass.prototype.xyz.call(this)

but it should be

Klass$1.prototype.xyz.call(this)

[goto-bus-stop]

I believe 0c06cae attempted to fix this—we didn't upgrade to the latest Bublé yet in acorn-node. Not sure if it's still an issue in 0.20.0

[kumavis]

I verified it's an issue on 0.20.0, the transpired output above is from that version

[goto-bus-stop]

Ohh I see, this is about super.xyz(), but the earlier fix was for super() in the constructor call only